Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v24.1.x] Stephan/revert polling removal #18176

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #18090

StephanDollberg and others added 5 commits April 30, 2024 21:12
…as deprecated"

This reverts commit c735156.

There is scenarios where polling with high debounce can be used to limit
fetch perf impact (at the cost of high latency).

(cherry picked from commit 03a9f27)
This reverts commit dd4676a.

Will be replaced with 23.3 commit

(cherry picked from commit 7262ff8)
This reverts commit 44bde8d.

Will be replaced with 23.3 commit

(cherry picked from commit 0cacd83)
The `kafka_latency_fetch_latency` metric originally measured the time
it'd take to complete one fetch poll. A fetch poll would create a fetch
plan then execute it in parallel on every shard. On a given shard
`fetch_ntps_in_parallel` would account for the majority of the execution time
of the plan.

Since fetches are no longer implemented by polling there isn't an
exactly equivalent measurement that can be assigned to the metric.

This commit instead records the duration of the first call to
`fetch_ntps_in_parallel` on every shard to the metric. This first call takes
as long as it would during a fetch poll. Hence the resulting measurement
should be close to the duration of a fetch poll.

(cherry picked from commit 44bde8d)
(cherry picked from commit afd1c9a)
@vbotbuildovich vbotbuildovich requested a review from a team as a code owner April 30, 2024 21:12
@vbotbuildovich vbotbuildovich added this to the v24.1.x-next milestone Apr 30, 2024
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Apr 30, 2024
@ballard26 ballard26 self-requested a review April 30, 2024 21:14
@piyushredpanda piyushredpanda modified the milestones: v24.1.x-next, v24.1.2 Apr 30, 2024
@StephanDollberg StephanDollberg merged commit 60d0cdc into redpanda-data:v24.1.x May 1, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants